Profile gui #62
Merged
Profile gui #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemencecousin
approved these changes
Jun 27, 2020
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/LayoutApartmentGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/LayoutApartmentGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/LayoutApartmentGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/LayoutApartmentGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/LayoutApartmentGUI.java
Outdated
Show resolved
Hide resolved
oliviercailloux
requested changes
Jun 29, 2020
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/AskOpinionForUtility.java
Outdated
Show resolved
Hide resolved
Comment on lines
+59
to
+60
| (Apartment c, Apartment d) -> | ||
| -Double.compare(linearAVF.getSubjectiveValue(c), linearAVF.getSubjectiveValue(d))); |
There was a problem hiding this comment.
Plus élégant d’utiliser Comparator#Comparing (OPT)
|
Bonjour, nous avons réalisé tous les changements nécessaires à la prise en compte de cette PR. |
oliviercailloux
approved these changes
Jul 1, 2020
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/AskOpinionForUtility.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/oliviercailloux/y2018/apartments/gui/AskOpinionForUtility.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour,
suite aux nombreux problèmes concernant QuestionPriceArea, nous avons fait une version compilant et se lançant correctement. La seule subtilité réside dans l'utilisation du Object à la place de QuestionPriceArea. Dans cette version, nous ne pouvons voir les questions dans le GUI Profile Questions.
Vous pourrez trouver ci-joint des captures d'écran de ce qui a été réalisé.
Cette PR n'a pas pour but d'être merge en l'état actuel. Une fois que la PR 45 aura été fusionnée, nous ferons les modifications nécessaires. Nous sommes prêt à finaliser cette tâche même après les examens et les derniers rendus afin de pouvoir aboutir ce travail longuement réfléchi.
Nous restons ouverts à vos propositions concernant cette PR, en considérant qu'il ne s'agit pas de la version finale. Vous pourrez tout de même y retrouver le travail que nous avons réalisé avec @MorganeFt.
Bonne journée